Smarty Forum Index Smarty
WARNING: All discussion is moving to https://reddit.com/r/smarty, please go there! This forum will be closing soon.

Bug in {popup} plugin?!!

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs
View previous topic :: View next topic  
Author Message
andre
Smarty Pro


Joined: 23 Apr 2003
Posts: 164
Location: Karlsruhe, Germany

PostPosted: Wed Dec 17, 2003 4:17 pm    Post subject: Bug in {popup} plugin?!! Reply with quote

Line 76 of the {popup} plugin (function.popup.php) reads
Code:
    if (!empty($function)) { $retval .= ",FUNCTION,'$function'"; }

This does not work - the single quotes around $function are wrong. The corrected line:
Code:
    if (!empty($function)) { $retval .= ",FUNCTION,$function"; }

Now the function call within JavaScript works for me Smile
Back to top
View user's profile Send private message
messju
Administrator


Joined: 16 Apr 2003
Posts: 3336
Location: Oldenburg, Germany

PostPosted: Fri Dec 19, 2003 5:23 pm    Post subject: Reply with quote

i fixed this in cvs. i also changed the parameter-handling of popup slightly. please tell me if i broke something with that.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP