Smarty Forum Index Smarty
WARNING: All discussion is moving to https://reddit.com/r/smarty, please go there! This forum will be closing soon.

Packagist entry for Smarty 3

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs
View previous topic :: View next topic  
Author Message
jbx
Smarty n00b


Joined: 25 Sep 2014
Posts: 3

PostPosted: Thu Sep 25, 2014 1:21 pm    Post subject: Packagist entry for Smarty 3 Reply with quote

The Packagist entry for Smarty is pointing to the root folder of the SVN trunk. This is making people using Smarty with composer download a lot of unneeded things (like Demo files and Documentation) into their application, when in actual fact they should be downloading just the distribution/libs directory.

Also the fact that the Packagist entry is pointing to the SVN repo instead of the github one (not sure if the github one is kept in synch) requires that users install SVN just to be able to install Smarty via Composer.

1. Put a composer.json in the distribution/libs folder
2. Change Packagist source repo URL to point to the distribution/libs

Preferably move the URL to the GitHub repo, if it is being maintained.
Back to top
View user's profile Send private message
jbx
Smarty n00b


Joined: 25 Sep 2014
Posts: 3

PostPosted: Tue Oct 14, 2014 9:56 pm    Post subject: The latest update screwed it up Reply with quote

It seems there was an update (3.1.20) to address this but it wasn't done correctly.

The documentation folder was removed but it still includes the /demo folder.

The composer.json file was not updated and still includes the path to distribution/libs/ which does not exist. Due to this composer fails to generate the autoload.php when running composer update.

Sad
Back to top
View user's profile Send private message
U.Tews
Administrator


Joined: 22 Nov 2006
Posts: 5068
Location: Hamburg / Germany

PostPosted: Wed Oct 15, 2014 12:51 am    Post subject: Reply with quote

composer.json was modified to use the zip file from the download page which does include the demo folder. By mistake the classmap of composer.json in the root folder did use the "distribution/libs/" path instead of "libs/".
This is now fixed.

The SVN and github is keptin sync.
Back to top
View user's profile Send private message
jbx
Smarty n00b


Joined: 25 Sep 2014
Posts: 3

PostPosted: Wed Oct 15, 2014 11:31 pm    Post subject: Packagist still failing for stable version Reply with quote

The Packagist entry has not been updated yet with a new stable release, so the latest stable release is still broken. Until v3.1.21 is put on (and the composer.json version is updated to reflect that) it will still be broken to anyone using the stable release. So for anyone using this in production releases and thus using the stable version the build is breaking.

On another note, if Github is being kept in sync it would be better if the packagist URL points to Github than the SVN URL, because Composer has special support for Github using their APIs, while SVN needs SVN tools to be installed separately (which is problematic for production servers).
Back to top
View user's profile Send private message
U.Tews
Administrator


Joined: 22 Nov 2006
Posts: 5068
Location: Hamburg / Germany

PostPosted: Sat Oct 18, 2014 1:14 am    Post subject: Reply with quote

Composer is now up running again. It does load the distribution currently from github.com/uwetews/smarty-dist. (This will change some time in the future)

On github v3.1.21 is alread tagged. The SVN gets updated tomorrow.

Use
"require": {
"smarty/smarty": "~3.1"
}
to get it.

You must run composer clearcache to get it working.
Back to top
View user's profile Send private message
Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP