Smarty Forum Index Smarty
WARNING: All discussion is moving to https://reddit.com/r/smarty, please go there! This forum will be closing soon.

popup function broken

 
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs
View previous topic :: View next topic  
Author Message
gabe
Smarty n00b


Joined: 30 Dec 2003
Posts: 3

PostPosted: Mon Feb 23, 2004 9:42 pm    Post subject: popup function broken Reply with quote

The code below used to work in 2.6.0-rc1 ...and we just updated to 2.6.2 and now this gives a javascript error. I suspect certain overlib options which take numeric arguments don't like the single quotes which now seem to be the default for all arguments. Things like WIDTH, OFFSETY, DELAY.

<a href="" onClick="return false;" {popup text="If you forget your password, we will use the answer you provide to the secret question to verify your identity.<br><br>Choose a Question/Answer that only you will know. It should not be related to your password in any way, unlikely to change over time, and extremely difficult for others to guess, even if they see your secret question." fgcolor= '#E68035' textcolor= '#FFFFFF' width='240' delay='50'}>What is this?</a>
Back to top
View user's profile Send private message
Duncan
Smarty Pro


Joined: 16 Dec 2003
Posts: 166

PostPosted: Mon Feb 23, 2004 11:15 pm    Post subject: Reply with quote

Please see this thread for a fix:
http://www.phpinsider.com/smarty-forum/viewtopic.php?t=1873
Back to top
View user's profile Send private message
messju
Administrator


Joined: 16 Apr 2003
Posts: 3336
Location: Oldenburg, Germany

PostPosted: Mon Feb 23, 2004 11:22 pm    Post subject: Reply with quote

I see. Thanks for pointing out this bug! I've fixed that in CVS, please try that version.

If you don't have a cvs-client you can grab the plugin from here:
http://cvs.php.net/co.php/smarty/libs/plugins/function.popup.php?r=1.12

greetings
messju
Back to top
View user's profile Send private message Send e-mail Visit poster's website
messju
Administrator


Joined: 16 Apr 2003
Posts: 3336
Location: Oldenburg, Germany

PostPosted: Mon Feb 23, 2004 11:26 pm    Post subject: Reply with quote

@duncan: It seems some issues with popup where fixed before 2.6.2, but not the Integers like width, height, timeout etc.
Back to top
View user's profile Send private message Send e-mail Visit poster's website
Duncan
Smarty Pro


Joined: 16 Dec 2003
Posts: 166

PostPosted: Tue Feb 24, 2004 9:24 am    Post subject: Reply with quote

Ah,
ok, I thought those were fixed in the CVS before already - at least all issues I experienced with the popup were fixed after grabbing the popup function file from the CVS back then.
Back to top
View user's profile Send private message
FEZ
Smarty Rookie


Joined: 21 Oct 2004
Posts: 6

PostPosted: Thu Oct 21, 2004 5:04 pm    Post subject: Reply with quote

There is still a problem with popup in 2.6.5-dev!
Gives a Java-script error!
FEZ
Back to top
View user's profile Send private message
kills
Smarty Elite


Joined: 28 May 2004
Posts: 493

PostPosted: Thu Oct 21, 2004 5:24 pm    Post subject: Reply with quote

FEZ wrote:
There is still a problem with popup in 2.6.5-dev!
Gives a Java-script error!
FEZ


which error?

line?

which Browser?
Back to top
View user's profile Send private message
FEZ
Smarty Rookie


Joined: 21 Oct 2004
Posts: 6

PostPosted: Thu Oct 21, 2004 5:26 pm    Post subject: Reply with quote

Oooops... Sorry

Line: 75
Error: Object required

FEZ
Back to top
View user's profile Send private message
Display posts from previous:   
This forum is locked: you cannot post, reply to, or edit topics.   This topic is locked: you cannot edit posts or make replies.    Smarty Forum Index -> Bugs All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP