Smarty

[Estigy]

Hi.

Smarty templates compile to functions named "content_" + uniqid('', false).

On our high traffic site, every now and then two different templates get compiled to the same function name, resulting in some very weird output: On the place, where the second template is to be inserted, the first template (with the same function name already in memory) shows up.

The code can be found 2x in smarty_internal_template.php and 1x in smarty_internal_compile_include.php.

I strongly encourage not only using uniqid() for generating the function name. Please add a checksum of the code or the filename to the identifier.

Thanks,
Estigy.

[Estigy]

Hi.

I did a quickfix for this that seems to work for me. The lines now look like this:

.... = 'content_' . str_replace('.', '_', uniqid('', true));

Including the content-hash or the filename still seems a better to do this, though.

Greets, E.

[U.Tews]

This has been fixed in the SVN trunk and will be include in 3.1.8

[Estigy]

Thanks!