Smarty

[gerard]

In my cache dir, I have a file:

cache/cacheid/groupid/compileid/%%39/399/3990E2F5%%page.html

Do the "%%39", "399", and "3990E2F5" mean anything? Why are those extra dirs even necessary? There's never more than one dir/file in each. Also, why are %%'s used?

[messju]

[gerard]

That seems like pretty long odds that there will be more than one file in a directory. I think smarty should make better use of cache sub_dirs - break them up into buckets or something.

[messju]

[gerard]

Uh, do you have numbers and proof? Concrete and non-superficial? Let's see it.

[boots]

@gerard: I think messju is saying that if you think you have a good idea to improve the mechanism, write a patch and submit it with benchmarks showing why it is better. Otherwise you'll find that the people who actually implemented the routine are already satisfied with its behaviour and don't feel the need to prove why it is better than a hypothetical design. That doesn't mean it can't be better than it is, but it does mean that if someone wants to improve it with a patch, the onus is on them to show that their patch is actually an improvement.

[gerard]

I figured a way to avoid the 32000 directory entry limit problem:

$cache_key="item|".implode('|', str_split((int)$_GET['id'], 4));