Smarty Forum Index Smarty
The discussions here are for Smarty, a template engine for the PHP programming language.

Incorrect version numbers in releases

 
Post new topic   Reply to topic    Smarty Forum Index -> Smarty Development
View previous topic :: View next topic  
Author Message
LoneWolfScripts
Smarty n00b


Joined: 25 May 2015
Posts: 2

PostPosted: Mon May 25, 2015 9:26 am    Post subject: Incorrect version numbers in releases Reply with quote

Hiya,

So we've been using version 2.6.26 for awhile now but we're upgrading our servers to php 5.6 and so are looking at upgrading to version 2.6.28 (for the preg_replace deprecated e) or maybe the latest 3.1.X.

So I've downloaded 2.6.26, 2.6.27 and 2.6.28. The package we've been running say it's 2.6.26 in the header and in the code, but the ones I've downloaded all say 2.6.25-dev in the code and the header. So without actually doing a file comparison and checking against the change log, I can't be sure that the releases are correct.

I also downloaded 3.1.19 -> 3.1.24. SMARTY_VERSION is somewhat inconsistent in that some of them just have the version, Some say "Smarty-3.1.XX" and 19 says Smarty-3.1.19-dev.

Now I can work around that, but down the road, I might not be the one maintaining the code and so it could end up being an issue, not to mention if anyone needs to write code that does any sort of version check.

Is this something that can easily be fixed in the releases or at least made consistent moving forward?

Thanks.
Back to top
View user's profile Send private message
AnrDaemon
Administrator


Joined: 03 Dec 2012
Posts: 1399

PostPosted: Mon May 25, 2015 10:31 am    Post subject: Reply with quote

You didn't say, WHERE you've downloaded them from?
Exact links to accompany your claims would go a long way towards fixing the issue. If there's an issue.
Back to top
View user's profile Send private message
LoneWolfScripts
Smarty n00b


Joined: 25 May 2015
Posts: 2

PostPosted: Mon May 25, 2015 8:05 pm    Post subject: Reply with quote

AnrDaemon wrote:
You didn't say, WHERE you've downloaded them from?
Exact links to accompany your claims would go a long way towards fixing the issue. If there's an issue.


Smarty -> Download -> Smarty 2 and 3 releases https://github.com/smarty-php/smarty/releases
Back to top
View user's profile Send private message
U.Tews
Administrator


Joined: 22 Nov 2006
Posts: 5067
Location: Hamburg / Germany

PostPosted: Wed May 27, 2015 8:48 pm    Post subject: Reply with quote

This has been addressed.

All future SMARTY_VERSION will look like "3.1.24" or "3.1.25-dev/x" for dev-master/trunk versions. Where 'x' stands for an update index of the dev-master versions.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    Smarty Forum Index -> Smarty Development All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group
Protected by Anti-Spam ACP